login  home  contents  what's new  discussion  bug reports     help  links  subscribe  changes  refresh  edit

Edit detail for #121 bogus <code>property change</code> comments revision 1 of 1

1
Editor:
Time: 2007/11/17 21:54:35 GMT-8
Note: property change

changed:
-
Some very aggressive search engines (spiders) seem to be following
form action="xxxx" references in pages as well as the usual href
links. As a result probes by such greedy theives can cause
unexpected changes to wiki web pages. One such example recently
has been the triggering of the 'Change' button on the Issue pages.
The script 'changeIssueProperties' should be more careful not to
record any change if the 'Change' action is triggered with no
actually changes.

From BillPage Thu Mar 10 23:09:25 -0600 2005
From: Bill Page
Date: Thu, 10 Mar 2005 23:09:25 -0600
Subject: patch for ZWiki/plugins/Tracker.py
Message-ID: <20050310230925-0600@page.axiom-developer.org>

<pre>
diff -au test/Products/ZWiki/plugins/Tracker.py main/Products/ZWiki/plugins/Tracker.py
--- test/Products/ZWiki/plugins/Tracker.py      2004-11-17 14:57:59.000000000 -0600
+++ main/Products/ZWiki/plugins/Tracker.py      2005-03-10 22:55:09.000000000 -0600
@@ -296,10 +296,11 @@
             if status != self.status:
                 comment += "Status: %s => %s \n" % (self.status,status)
                 self.manage_changeProperties(status=status)
-        log = log or 'property change'
-        self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
-        self.setLastEditor(REQUEST)
-        self.reindex_object()
+        if log or (comment != ''):
+            log = log or 'property change'
+            self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
+            self.setLastEditor(REQUEST)
+            self.reindex_object()
         if REQUEST: REQUEST.RESPONSE.redirect(self.page_url())

     def category_index(self):
</pre>

From BillPage Thu Mar 10 23:10:04 -0600 2005
From: Bill Page
Date: Thu, 10 Mar 2005 23:10:04 -0600
Subject: property change
Message-ID: <20050310231004-0600@page.axiom-developer.org>

Status: open => testing 


From BillPage Sat Oct 1 15:25:02 -0500 2005
From: Bill Page
Date: Sat, 01 Oct 2005 15:25:02 -0500
Subject: property change
Message-ID: <20051001152502-0500@wiki.axiom-developer.org>

Name: '#121 bogus 'property change' comments' => '#121 bogus <code>property change</code> comments' 
Status: testing => closed 


Submitted by : (unknown) at: 2007-11-17T21:54:35-08:00 (14 years ago)
Name :
Axiom Version :
Category : Severity : Status :
Optional subject :  
Optional comment :

Some very aggressive search engines (spiders) seem to be following form action="xxxx" references in pages as well as the usual href links. As a result probes by such greedy theives can cause unexpected changes to wiki web pages. One such example recently has been the triggering of the Change button on the Issue pages. The script changeIssueProperties should be more careful not to record any change if the Change action is triggered with no actually changes.

patch for ZWiki/plugins/Tracker.py --Bill Page, Thu, 10 Mar 2005 23:09:25 -0600 reply
diff -au test/Products/ZWiki/plugins/Tracker.py main/Products/ZWiki/plugins/Tracker.py
--- test/Products/ZWiki/plugins/Tracker.py      2004-11-17 14:57:59.000000000 -0600
+++ main/Products/ZWiki/plugins/Tracker.py      2005-03-10 22:55:09.000000000 -0600
@@ -296,10 +296,11 @@
             if status != self.status:
                 comment += "Status: %s => %s \n" % (self.status,status)
                 self.manage_changeProperties(status=status)
-        log = log or property change
-        self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
-        self.setLastEditor(REQUEST)
-        self.reindex_object()
+        if log or (comment != ''):
+            log = log or property change
+            self.comment(text=comment, subject_heading=log, REQUEST=REQUEST)
+            self.setLastEditor(REQUEST)
+            self.reindex_object()
         if REQUEST: REQUEST.RESPONSE.redirect(self.page_url())

def category_index(self):

property change --Bill Page, Thu, 10 Mar 2005 23:10:04 -0600 reply
Status: open => testing

property change --Bill Page, Sat, 01 Oct 2005 15:25:02 -0500 reply
Name: '#121 bogus property change comments' => '#121 bogus property change comments' Status: testing => closed