login  home  contents  what's new  discussion  bug reports help  links  subscribe  changes  refresh  edit

# Edit detail for #278 'simplifyLog' cannot cope with 'sqrt' revision 4 of 7

 1 2 3 4 5 6 7 Editor: alfredo Time: 2008/08/28 18:36:43 GMT-7 Note:

added:

From wh-sandbox:

\begin{verbatim}

@@ -623,10 +623,13 @@
-- like to combine it with a log term.
terms :List F := [simplifyLog(term) for term in termList::List(F)]
exprs :List F := []
-        for i in 1..#terms repeat
-          if retractIfCan(terms.i)@Union(FPR,"failed") case FPR then
-            exprs := cons(terms.i,exprs)
-            terms := delete!(terms,i)
+        nterms :List F := []
+        for term in terms repeat
+          if retractIfCan(term)@Union(FPR,"failed") case FPR then
+            exprs := cons(term, exprs)
+          else
+            nterms := cons(term, nterms)
+        terms := nterms
if not empty? exprs then
foundLog := false
i : NonNegativeInteger := 0
\end{verbatim}


 Submitted by : (unknown) at: 2007-11-17T22:20:15-08:00 (15 years ago) Name : Axiom Version : default friCAS-20090114 Axiom-20050901 OpenAxiom-20091012 OpenAxiom-20110220 OpenAxiom-Release-141 Category : general Severity : critical serious normal minor wishlist Status : open pending closed Optional subject :   Optional comment :

axiom
simplifyLog(2*sqrt(2)*log(2))
 (1)
Type: Expression Integer

It's perhaps the line for i in 1..#terms repeat in manip.spad file and simplifyLog1 function to change in for i in #term..1 by -1 repeat because there is a delete!(terms,i) in the loop.

It's perhaps necessary to add exprs := reverse! exprs at the end of the loop, if we want to remain the order of the terms.

FMy?.

fixed in FriCAS? --kratt6, Thu, 20 Dec 2007 01:50:37 -0800 reply
Category: Axiom Interpreter => Axiom Library Status: open => fix proposed

Status: fix proposed => fixed somewhere

no patch available

From wh-sandbox: